Re: [PATCH -next V10 04/10] riscv: entry: Convert to generic entry

[Björn Töpel]

Guo Ren <guoren@xxxxxxxxxx> writes:

>> >  - Little modification on ret_from_fork & ret_from_kernel_thread
>>
>> What changes?
>  ENTRY(ret_from_fork)
> +       call schedule_tail
> +       move a0, sp /* pt_regs */
>         la ra, ret_from_exception
> -       tail schedule_tail
> +       tail syscall_exit_to_user_mode
>  ENDPROC(ret_from_fork)
>
>  ENTRY(ret_from_kernel_thread)
>         call schedule_tail
>         /* Call fn(arg) */
> -       la ra, ret_from_exception
>         move a0, s1
> -       jr s0
> +       jalr s0
> +       move a0, sp /* pt_regs */
> +       la ra, ret_from_exception
> +       tail syscall_exit_to_user_mode
>  ENDPROC(ret_from_kernel_thread)

Thanks for clearing that up! It's more useful to have a descriptive
text, than just "these functions were changed". (Why instead of what)


Cheers,
Björn