Re: [for-next][PATCH 13/25] x86/mm/kmmio: Use rcu_read_lock_sched_notrace()

From: Steven Rostedt
Date: Sat Dec 10 2022 - 13:34:59 EST


On Sat, 10 Dec 2022 09:47:53 -0800
"Paul E. McKenney" <paulmck@xxxxxxxxxx> wrote:

> > Note, the preempt_disable() is still needed as it uses preempt_enable_no_resched().
> >

...

> Executable code can be the best form of comment. ;-)
>
> This does mess with preempt_count() redundantly, but the overhead from
> that should be way down in the noise.

I was going to remove it, but then I realized that it would be a functional
change, as from the comment above, it uses "preempt_enable_no_resched(),
which there is not a rcu_read_unlock_sched() variant.

>
> Acked-by: Paul E. McKenney <paulmck@xxxxxxxxxx>

Thanks! I'll add this to the commit.

-- Steve