Re: [RFC net-next v6 2/2] bnxt: Use generic HBH removal helper in tx path

[Michael Chan]

On Fri, Dec 9, 2022 at 8:16 PM Coco Li <lixiaoyan@xxxxxxxxxx> wrote:
>
> Eric Dumazet implemented Big TCP that allowed bigger TSO/GRO packet sizes
> for IPv6 traffic. See patch series:
> 'commit 89527be8d8d6 ("net: add IFLA_TSO_{MAX_SIZE|SEGS} attributes")'
>
> This reduces the number of packets traversing the networking stack and
> should usually improves performance. However, it also inserts a
> temporary Hop-by-hop IPv6 extension header.
>
> Using the HBH header removal method in the previous patch, the extra header
> be removed in bnxt drivers to allow it to send big TCP packets (bigger
> TSO packets) as well.
>
> Tested:
> Compiled locally
>
> To further test functional correctness, update the GSO/GRO limit on the
> physical NIC:
>
> ip link set eth0 gso_max_size 181000
> ip link set eth0 gro_max_size 181000
>
> Note that if there are bonding or ipvan devices on top of the physical
> NIC, their GSO sizes need to be updated as well.
>
> Then, IPv6/TCP packets with sizes larger than 64k can be observed.
>
> Signed-off-by: Coco Li <lixiaoyan@xxxxxxxxxx>

Reviewed-by: Michael Chan <michael.chan@xxxxxxxxxxxx>
Tested-by: Michael Chan <michael.chan@xxxxxxxxxxxx>

Thanks.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature