Re: [PATCH v2 3/3] regulator: axp20x: Add support for AXP1530 variant

[Christophe JAILLET]

Le 10/12/2022 à 00:46, Martin Botka a écrit :
> AXP1530 has a few regulators that are controlled via I2C Bus.
>
> Add support for them.
>
> Signed-off-by: Martin Botka <martin.botka-KtrmGDJU8+nZ+VzJOa5vwg@xxxxxxxxxxxxxxxx>
> ---
>   drivers/regulator/axp20x-regulator.c | 44 ++++++++++++++++++++++++++++
>   1 file changed, 44 insertions(+)
>
> diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
> index d260c442b788..ca422311a996 100644
> --- a/drivers/regulator/axp20x-regulator.c
> +++ b/drivers/regulator/axp20x-regulator.c

[...]

> @@ -1252,6 +1292,10 @@ static int axp20x_regulator_probe(struct platform_device *pdev)
>   		drivevbus = of_property_read_bool(pdev->dev.parent->of_node,
>   						  "x-powers,drive-vbus-en");
>   		break;
> +		case AXP1530_ID:

Nit: indentation.

> +		regulators = axp1530_regulators;
> +		nregulators = AXP1530_REG_ID_MAX;
> +		break;
>   	default:
>   		dev_err(&pdev->dev, "Unsupported AXP variant: %ld\n",
>   			axp20x->variant);