Re: [PATCH 0/5] staging: drivers: mfd: Add MAX77541 MFD and related device drivers

From: Jonathan Cameron
Date: Sun Dec 11 2022 - 08:55:03 EST


On Sun, 11 Dec 2022 15:34:10 +0200
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> On Sun, Dec 11, 2022 at 12:20:43PM +0000, Jonathan Cameron wrote:
> > On Wed, 7 Dec 2022 13:09:34 +0200
> > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > > On Wed, Dec 07, 2022 at 12:08:39PM +0300, Okan Sahin wrote:
> > > > This patchset adds mfd, regulator and adc driver and related bindings.The patches
> > > > are required to be applied in sequence.
> > >
> > > You have an indentation / wrapping issues in the above text.
> > >
> > > Nevertheless, why staging? What does it mean?
> >
> > The main reason to go via staging is because a driver is sitting out
> > of tree and it is useful to bring it in on the basis that it can then be
> > cleaned up in tree before moving out of staging.
>
> But files are not in staging. Me being confused.

I noticed that when I got to the patches :)
Odd indeed - I'm guessing some cut and paste gone wrong.

Jonathan

>
> > For a relatively small driver like this, that's hard to argue. Just
> > clean it up in response to review feedback and then we can take it
> > directly into relevant subsystems in the main tree.
>