Re: [PATCH 4/4] arm64: dts: qcom: sm8250: move sound and codec nodes out of soc

From: Krzysztof Kozlowski
Date: Sun Dec 11 2022 - 15:13:42 EST


On 10/12/2022 13:31, Konrad Dybcio wrote:
>
>
> On 10.12.2022 12:57, Krzysztof Kozlowski wrote:
>> The sound and codec nodes are not a property of a soc, but rather board
>> as it describes the sound configuration.
> * in this case, there exist SoC-internal codecs

wcd9380 is not SoC internal, so to which codec you refer to? Sound node
is for sound configuration, not codec, and sound configuration is board
specific.

>
> It also does not have unit
>> address:
>>
>> sm8250-hdk.dtb: soc@0: sound: {} should not be valid under {'type': 'object'}
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Best regards,
Krzysztof