[PATCH net-next v2] net: ipa: Remove redundant dev_err()

From: Kang Minchul
Date: Mon Dec 12 2022 - 02:19:07 EST


Function dev_err() is redundant because platform_get_irq_byname()
already prints an error.

Also, platform_get_irq_byname() can't return 0 so ret <= 0
should be ret < 0.

Signed-off-by: Kang Minchul <tegongkang@xxxxxxxxx>
---
Changes in v2:
- Annotate patch with net-next.
- Remove unnecessary comparison with zero.

drivers/net/ipa/gsi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
index 55226b264e3c..a4f19f7f188e 100644
--- a/drivers/net/ipa/gsi.c
+++ b/drivers/net/ipa/gsi.c
@@ -1967,11 +1967,8 @@ int gsi_init(struct gsi *gsi, struct platform_device *pdev, bool prefetch,

/* Get the GSI IRQ and request for it to wake the system */
ret = platform_get_irq_byname(pdev, "gsi");
- if (ret <= 0) {
- dev_err(gsi->dev,
- "DT error %d getting \"gsi\" IRQ property\n", ret);
+ if (ret < 0)
return ret ? : -EINVAL;
- }
irq = ret;

ret = request_irq(irq, gsi_isr, 0, "gsi", gsi);
--
2.34.1