Re: [PATCH] memory: omap-gpmc: fix wait pin validation

From: Roger Quadros
Date: Mon Dec 12 2022 - 04:09:09 EST




On 09/12/2022 14:31, B. Niedermayr wrote:
> From: Benedikt Niedermayr <benedikt.niedermayr@xxxxxxxxxxx>
>
> This bug has been introduced after switching from -1 to UINT_MAX
> for GPMC_WAITPIN_INVALID.
>
> The bug leads to an error when the optional gpmc,wait-pin
> dt-property is not used:
>
> ...
> gpmc_cs_program_settings: invalid wait-pin (-1)
> ...
>
> Signed-off-by: Benedikt Niedermayr <benedikt.niedermayr@xxxxxxxxxxx>
> Fixes: 8dd7e4af5853 ("memory: omap-gpmc: fix coverity issue "Control flow issues"")
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>

Acked-by: Roger Quadros <rogerq@xxxxxxxxxx>