Re: [PATCH] iommu/arm-smmu-qcom: Add SM8150 DPU compatible

From: Konrad Dybcio
Date: Mon Dec 12 2022 - 06:23:01 EST




On 12.12.2022 12:20, Dmitry Baryshkov wrote:
>
>
> On 12 December 2022 14:00:10 GMT+03:00, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>>
>>
>> On 12.12.2022 11:58, Dmitry Baryshkov wrote:
>>>
>>>
>>> On 12 December 2022 13:06:16 GMT+03:00, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>>>> From: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
>>>>
>>>> Add the SM8150 DPU compatible to clients compatible list, as it also
>>>> needs the workarounds.
>>>
>>> Please rebase on top of linux-next, this part was rewritten.
>> This one wasn't, but yeah it is based on some local changes
>> (see 6350/6375)..
>
> It was,
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c?h=next-20221208#n498
We're not looking at the same thing, this patch adds a compatible
for 8150's mdss so that it can be matched as a client, not a
compatible for the SMMU itself (which itself has been merged
dinosaur years ago).

Konrad
>
>>
>> Konrad
>>>
>>>
>>>>
>>>> Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>>>> ---
>>>> Depends on the binding here:
>>>>
>>>> [1] https://lore.kernel.org/linux-arm-msm/20221212093315.11390-1-konrad.dybcio@xxxxxxxxxx/T/#t
>>>>
>>>> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>>> index 6610f5d2877d..cd74c1efcfde 100644
>>>> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>>> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>>> @@ -255,6 +255,7 @@ static const struct of_device_id qcom_smmu_client_of_match[] __maybe_unused = {
>>>> { .compatible = "qcom,sdm845-mss-pil" },
>>>> { .compatible = "qcom,sm6350-mdss" },
>>>> { .compatible = "qcom,sm6375-mdss" },
>>>> + { .compatible = "qcom,sm8150-mdss" },
>>>> { .compatible = "qcom,sm8250-mdss" },
>>>> { }
>>>> };
>>>
>