Re: [PATCH] f2fs: don't set FI_COMPRESS_RELEASED if file is not compressed

[Chao Yu]

On 2022/12/10 4:19, Jaegeuk Kim wrote:
> On 12/08, zhoudan8 wrote:
> > In compress_mode=user, f2fs_release_compress_blocks()
> >   does not verify whether it has been compressed and
> >   sets FI_COMPRESS_RELEASED directly. which will lead to
> > return -EINVAL after calling compress.
> > To fix it,let's do not set FI_COMPRESS_RELEASED if file
> > is not compressed.
>
> Do you mean you want to avoid EINVAL on a file having FI_COMPRESS_RELEASED
> with zero i_compr_blokcs?
>
> I think the current logic is giving the error on a released file already.

IMO, if i_compr_blocks is zero, it's better to return -EINVAL in
f2fs_release_compress_blocks(), as there will be no benefit after the conversion.

Thanks,

> > Signed-off-by: zhoudan8 <zhoudan8@xxxxxxxxxx>
> > ---
> >   fs/f2fs/file.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > index 82cda1258227..f32910077df6 100644
> > --- a/fs/f2fs/file.c
> > +++ b/fs/f2fs/file.c
> > @@ -3451,14 +3451,13 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg)
> >   	ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX);
> >   	if (ret)
> >   		goto out;
> > -
> > -	set_inode_flag(inode, FI_COMPRESS_RELEASED);
> >   	inode->i_ctime = current_time(inode);
> >   	f2fs_mark_inode_dirty_sync(inode, true);
> >   
> >   	if (!atomic_read(&F2FS_I(inode)->i_compr_blocks))
> >   		goto out;
> >   
> > +	set_inode_flag(inode, FI_COMPRESS_RELEASED);
> >   	f2fs_down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
> >   	filemap_invalidate_lock(inode->i_mapping);
> >   
> > --
> > 2.38.1