Re: [PATCH v10 28/33] arm64: dts: rockchip: rk3399: add crypto node

[Corentin LABBE]

Le Sun, Dec 11, 2022 at 09:51:42AM -0600, Rob Herring a écrit :
> On Tue, Sep 27, 2022 at 2:56 AM Corentin Labbe <clabbe@xxxxxxxxxxxx> wrote:
> >
> > The rk3399 has a crypto IP handled by the rk3288 crypto driver so adds a
> > node for it.
> >
> > Tested-by Diederik de Haas <didi.debian@xxxxxxxxx>
> > Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > index 92c2207e686c..4391aea25984 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > @@ -582,6 +582,26 @@ saradc: saradc@ff100000 {
> >                 status = "disabled";
> >         };
> >
> > +       crypto0: crypto@ff8b0000 {
> > +               compatible = "rockchip,rk3399-crypto";
> > +               reg = <0x0 0xff8b0000 0x0 0x4000>;
> > +               interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH 0>;
> > +               clocks = <&cru HCLK_M_CRYPTO0>, <&cru HCLK_S_CRYPTO0>, <&cru SCLK_CRYPTO0>;
> > +               clock-names = "hclk_master", "hclk_slave", "sclk";
> > +               resets = <&cru SRST_CRYPTO0>, <&cru SRST_CRYPTO0_S>, <&cru SRST_CRYPTO0_M>;
> > +               reset-names = "master", "lave", "crypto";
> 
> This doesn't match the binding:
> 
> crypto@ff8b8000: reset-names:2: 'crypto-rst' was expected
> crypto@ff8b0000: reset-names:2: 'crypto-rst' was expected
> crypto@ff8b0000: reset-names:1: 'slave' was expected
> 

Hello

I will send a patch to fix that

Regards