Re: [RFC PATCH v4 1/1] serial: core: Start managing serial controllers to enable runtime PM

From: Tony Lindgren
Date: Mon Dec 12 2022 - 07:53:32 EST


* Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> [221212 12:49]:
> On Mon, 12 Dec 2022, Tony Lindgren wrote:
>
> > Hi Ilpo,
> >
> > * Tony Lindgren <tony@xxxxxxxxxxx> [221208 11:13]:
> > > * Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> [221208 10:48]:
> > > > With the other patch on top of this, yes, I did see uninitialized
> > > > port->port_dev already in serial_core_add_one_port()->uart_configure_port().
> > > > While that could be solved by removing the pm_runtime_*() calls from
> > > > there, I think it's a generic problem because after
> > > > serial_core_add_one_port() the port can have anything happening on it, no?
> > >
> > > OK. Sounds like it should get sorted out by moving the call to
> > > serial_core_add_one_port() to happen after the devices are created.
> >
> > Can you give a try with the patch below and see if it works for you?
>
> This one worked, yes.

OK good to hear. I'll send out v5 after -rc1 then.

Thanks,

Tony