On Mon, Dec 12, 2022 at 12:13:54PM +0100, Oliver Neukum wrote:
1. that the function exists and its purpose
That should be apparent from the function name (and implementation).
2. its parameters
Apparent from the prototype.
But sure, it would not show up in generated documentation (like many
other functions).
it seems. Not sure how much value there is in that, though.
And in this case there was also no kernel doc for usb_get_intfdata()
which is equally self documenting. Why add redundant docs for only one
of these functions?
I'd rather drop this particular documentation which was added due to a
misunderstanding then go down the rabbit hole of adding mindless kernel
doc to every helper we have.
Yes. The (device group) attributes are removed by driver core before
->remove() is called, otherwise you'd have an even bigger issue with the
driver data itself which is typically deallocated before the pointer is