Re: [PATCH v11 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

[Dmitry Baryshkov]

On 13 December 2022 02:41:55 GMT+03:00, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote:
>Hi Dmitry
>
>On 12/12/2022 2:35 PM, Dmitry Baryshkov wrote:
>> On Mon, 12 Dec 2022 at 19:51, Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx> wrote:
>>> 
>>> 
>>> On 12/8/2022 4:35 PM, Dmitry Baryshkov wrote:
>>>> On 09/12/2022 02:22, Kuogee Hsieh wrote:
>>>>> 
>>>>> On 12/8/2022 4:11 PM, Dmitry Baryshkov wrote:
>>>>>> On 09/12/2022 01:38, Kuogee Hsieh wrote:
>>>>>>> 
>>>>>>> On 12/8/2022 3:33 PM, Dmitry Baryshkov wrote:
>>>>>>>> On 09/12/2022 00:36, Kuogee Hsieh wrote:
>>>>>>>>> Add both data-lanes and link-frequencies property into endpoint
>>>>>>>>> 
>>>>>>>>> Changes in v7:
>>>>>>>>> -- split yaml out of dtsi patch
>>>>>>>>> -- link-frequencies from link rate to symbol rate
>>>>>>>>> -- deprecation of old data-lanes property
>>>>>>>>> 
>>>>>>>>> Changes in v8:
>>>>>>>>> -- correct Bjorn mail address to kernel.org
>>>>>>>>> 
>>>>>>>>> Changes in v10:
>>>>>>>>> -- add menu item to data-lanes and link-frequecnis
>>>>>>>>> 
>>>>>>>>> Changes in v11:
>>>>>>>>> -- add endpoint property at port@1
>>>>>>>>> 
>>>>>>>>> Signed-off-by: Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx>`
>>>>>>>> 
>>>>>>>> Applying: dt-bindings: msm/dp: add data-lanes and link-frequencies
>>>>>>>> property
>>>>>>>> .git/rebase-apply/patch:47: trailing whitespace.
>>>>>>>> 
>>>>>>>> .git/rebase-apply/patch:51: trailing whitespace.
>>>>>>>> 
>>>>>>>> 
>>>>>>>> Also the dt_binding_check fails with an error for this schema. And
>>>>>>>> after fixing the error in the schema I faced an example validation
>>>>>>>> error. Did you check that the schema is correct and that the
>>>>>>>> example validates against the schema?
>>>>>>> 
>>>>>>> yes, but i run "make dt_binding_check
>>>>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/msm/dp-controller.yaml"
>>>>>>> at mu v5.15 branch since
>>>>>> 
>>>>>> I wouldn't ask you to post the log here. But I don't think that
>>>>>> either of the errors that I see here is related to 5.15 vs 6.1-rc.
>>>>>> 
>>>>>> In fact after applying this patch against 5.15 I saw the expected
>>>>>> failure:
>>>>>> 
>>>>>> Documentation/devicetree/bindings/display/msm/dp-controller.yaml:
>>>>>> properties:required: ['port@0', 'port@1'] is not of type 'object',
>>>>>> 'boolean'
>>>>>> Documentation/devicetree/bindings/display/msm/dp-controller.yaml:
>>>>>> properties: 'required' should not be valid under {'$ref':
>>>>>> '#/definitions/json-schema-prop-names'}
>>>>>> Documentation/devicetree/bindings/display/msm/dp-controller.yaml:
>>>>>> ignoring, error in schema: properties: required
>>>>>> 
>>>>>>> 
>>>>>>> "make dt_binding_check" does not work at msm-next branch.
>>>>>> 
>>>>>> I went ahead and just checked.
>>>>>> 
>>>>>> `make dt_binding_check DT_SCHEMA_FILES=display/msm`  works cleanly
>>>>>> in msm-next and reports a single example-related warning in
>>>>>> msm-next-lumag. I pushed a patch to fix that warning (wich can
>>>>>> hopefully be picked up by Abhinav into msm-fixes). So you can assume
>>>>>> that both these branches have consistent error-free display/msm
>>>>>> schemas.
>>>>>> 
>>>>> I have clean msm-next branch (without my data-lines yaml patch
>>>>> applied) and run "make dt_binding_check
>>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/msm/dp-controller.yaml",
>>>>> then I saw below error messages.
>>>>> 
>>>>> Have you run into this problem?
>>>> 
>>>> No.
>>> 
>>> Did you do anything to fix "older dtschema instance"?
>> 
>> I did not since I hadn't had such a problem. I can refer again to the
>> steps I provided you beforehand. The email was sent 6 days ago. No
>> answer from your side since that time.
>> 
>>> I had run  "pip3 install dtschema --upgrade" and still not work.
>> 
>> Can you please post a full log of this command?
>> 
>>> 
>>> D you know how to fix this problem?
>>> 
>>> Thanks,
>>> 
>>> kuogee
>>> 
>>> sort: -:2: disorder: 2022.1
>>> ERROR: dtschema minimum version is v2022.3
>>> make[2]: *** [check_dtschema_version] Error 1
>>> make[1]: *** [dt_binding_check] Error 2
>>> make: *** [__sub-make] Error 2
>> 
>> Please add the output of:
>> 
>> which dt-validate
>> dt-validate -V
>> 
>> And also a full log of your failing kernel build.
>> 
>> 
>> 
>>> I had run "pip3 install dtschema --upgrade" according Rob Herring response.
>>> but it still shows same problem.
>>> Please let know how can I fix this problem.
>>> 
>>>> 
>>>>> 
>>>>>     HOSTCC  scripts/basic/fixdep
>>>>>     HOSTCC  scripts/dtc/dtc.o
>>>>>     HOSTCC  scripts/dtc/flattree.o
>>>>>     HOSTCC  scripts/dtc/fstree.o
>>>>>     HOSTCC  scripts/dtc/data.o
>>>>>     HOSTCC  scripts/dtc/livetree.o
>>>>>     HOSTCC  scripts/dtc/treesource.o
>>>>>     HOSTCC  scripts/dtc/srcpos.o
>>>>>     HOSTCC  scripts/dtc/checks.o
>>>>>     HOSTCC  scripts/dtc/util.o
>>>>>     LEX     scripts/dtc/dtc-lexer.lex.c
>>>>>     HOSTCC  scripts/dtc/dtc-lexer.lex.o
>>>>>     HOSTCC  scripts/dtc/dtc-parser.tab.o
>>>>>     HOSTLD  scripts/dtc/dtc
>>>>> sort: -:2: disorder: 2022.1
>>>>> ERROR: dtschema minimum version is v2022.3
>>>>> make[2]: *** [check_dtschema_version] Error 1
>>>>> make[1]: *** [dt_binding_check] Error 2
>>>>> make: *** [__sub-make] Error 2
>>>> 
>>>> This means that somewhere in your path you have an older dtschema
>>>> instance.
>>>> 
>>>> When you sent me a question regarding this error, I asked for the
>>>> additional info. You provided none. Instead you went on sending the
>>>> untested patch that doesn't work.
>>> 
>>> since i can not test it on msm-next so that I did test it at my v5-15
>>> branch.
>> 
>> Wrong.
>> 
>>> 
>>> besides, i think i have to sent the whole series patches include this
>>> one to address your new comments on other patch.
>>> 
>>> is this correct?
>> 
>> No. Please fix your system first, validate your patches and send them
>> afterwards. You can not expect others to do your job.
>> 
>
>Just finished working with kuogee on this. This issue had been reported by few others earlier (example https://lore.kernel.org/lkml/bc9be279-a130-d5e7-4397-bbb389d14403@xxxxxxxxx/T/).

Thanks a lot for helping Kuogee!


>
>So let me summarize the fix:
>
>1) We do need up upgrade the dtschema first
>
>pip3 install git+https://github.com/devicetree-org/dt-schema.git@main

I'd stick to the released version, unless there is any indication that the trunk has any significant features. Rob, Krzysztof, please correct me if I'm wrong.


>
>2) Python version issues were hitting some of the developers so even if we had the right version installed the PATH wasnt pointing to the right one

Yes, that is what I expected, when I asked for the pip command log and for the `which' command output.

I usually install dtschema to my user's dir and add ~/.local/bin to PATH.

>
>3) We had to install yamllint
>
>We have documented these now for the benefit of others internally.
>
>With all these 3 done, we can compile msm-next-lumag using
>make dt_binding_check DT_SCHEMA_FILES=display/msm
>
>Apologies for the setup issues on our end. These are resolved now and kuogee will post a v12 for this.

Great, I'm looking forward to seeing it and finally merging it!


>
>Thanks
>
>Abhinav
>> --
>> With best wishes
>> Dmitry

-- 
With best wishes
Dmitry