Re: [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask

From: Horatiu Vultur
Date: Tue Dec 13 2022 - 02:30:43 EST


The 12/12/2022 13:02, Jakub Kicinski wrote:
>
> On Fri, 9 Dec 2022 13:07:01 +0100 Horatiu Vultur wrote:
> > case VCAP_FIELD_U128:
> > + value = data->u128.value;
> > + mask = data->u128.value;
>
> If setting both to value is intentional - please mention in the commit
> message. Otherwise this looks odd.

It should not be both set to value. Will fix this in th next version.

--
/Horatiu