Re: [PATCH v4 0/2] ceph: fix the use-after-free bug for file_lock

From: Jeff Layton
Date: Tue Dec 13 2022 - 07:47:17 EST


On Tue, 2022-12-13 at 20:11 +0800, xiubli@xxxxxxxxxx wrote:
> From: Xiubo Li <xiubli@xxxxxxxxxx>
>
> Changed in V4:
> - repeat the afs in fs.h instead of adding ceph specific header file
>
> Changed in V3:
> - switched to vfs_inode_has_locks() helper to fix another ceph file lock
> bug, thanks Jeff!
> - this patch series is based on Jeff's previous VFS lock patch:
> https://patchwork.kernel.org/project/ceph-devel/list/?series=695950
>
> Changed in V2:
> - switch to file_lock.fl_u to fix the race bug
> - and the most code will be in the ceph layer
>
> Xiubo Li (2):
> ceph: switch to vfs_inode_has_locks() to fix file lock bug
> ceph: add ceph specific member support for file_lock
>
> fs/ceph/caps.c | 2 +-
> fs/ceph/locks.c | 24 ++++++++++++++++++------
> fs/ceph/super.h | 1 -
> include/linux/fs.h | 3 +++
> 4 files changed, 22 insertions(+), 8 deletions(-)
>

Both patches look good to me. You can add:

Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>