Re: [PATCH 1/2] dt-bindings: hwmon: correct indentation and style in examples

From: Rob Herring
Date: Tue Dec 13 2022 - 08:46:45 EST



On Tue, 13 Dec 2022 10:26:41 +0100, Krzysztof Kozlowski wrote:
> Fix mixed indentation to 4-spaces, remove unnecessary suffix from
> i2c node name and use lower-case hex. No functional impact.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> .../bindings/hwmon/adi,adm1177.yaml | 12 ++---
> .../bindings/hwmon/adi,adm1266.yaml | 6 +--
> .../bindings/hwmon/adi,axi-fan-control.yaml | 20 ++++-----
> .../bindings/hwmon/adi,ltc2947.yaml | 20 ++++-----
> .../bindings/hwmon/adi,ltc2992.yaml | 26 +++++------
> .../devicetree/bindings/hwmon/amd,sbrmi.yaml | 6 +--
> .../devicetree/bindings/hwmon/amd,sbtsi.yaml | 6 +--
> .../devicetree/bindings/hwmon/iio-hwmon.yaml | 8 ++--
> .../bindings/hwmon/national,lm90.yaml | 44 +++++++++----------
> .../bindings/hwmon/ntc-thermistor.yaml | 2 +-
> .../bindings/hwmon/nuvoton,nct7802.yaml | 16 +++----
> .../devicetree/bindings/hwmon/ti,tmp513.yaml | 22 +++++-----
> .../bindings/hwmon/ti,tps23861.yaml | 16 +++----
> 13 files changed, 102 insertions(+), 102 deletions(-)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/hwmon/adi,ltc2992.example.dts:22.24-38.15: Warning (i2c_bus_reg): /example-0/i2c/ltc2992@6F: I2C bus unit address format error, expected "6f"

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221213092643.20404-1-krzysztof.kozlowski@xxxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.