Re: [PATCH 4/4] arm64: dts: qcom: sc8280xp: add missing spi nodes

From: Shazad Hussain
Date: Tue Dec 13 2022 - 09:46:23 EST




On 12/13/2022 8:06 PM, Brian Masney wrote:
On Tue, Dec 13, 2022 at 02:08:47PM +0100, Javier Martinez Canillas wrote:
On 12/13/22 14:02, Krzysztof Kozlowski wrote:
On 13/12/2022 13:27, Brian Masney wrote:
qcom,spi-video-codec is still not specific enough. You need to describe
real device behind spidev. To be clear - you do not describe userspace,
but the device.


Agree.

I believe Brian just used "qcom,spi-video-codec" as an example but is only
a make up name to illustrate the concept. QC needs to determine what would
be the correct <vendor,device> tuple for the IP block that the user-space
driver will drive.

Yes, that was just an example.

Shazad: Is this thread clear about what QC needs for spidev? I'll let QC
take care of sending patch(es) to add the various compatibles since I'm
not sure what hardware will be backed by spidev.


I think for qup2_spi22 we can use qcom,spi-msm-codec-slave as compatible. As this is what used in downstream.

I'll take care of making sure that sc8280xp.dtsi gets the spi controller
nodes added.

Yes, for qup1_spi9 we can add it later when needed. This is for display/touch 2nd.

Shazad


Brian