Re: [PATCH net-next v6] virtio/vsock: replace virtio_vsock_pkt with sk_buff

From: Bobby Eshleman
Date: Tue Dec 13 2022 - 13:20:20 EST


On Tue, Dec 13, 2022 at 04:43:04PM +0100, Stefano Garzarella wrote:
> On Tue, Dec 13, 2022 at 10:06:23AM -0500, Michael S. Tsirkin wrote:
> > On Tue, Dec 13, 2022 at 11:22:32AM +0100, Stefano Garzarella wrote:
> > > > + if (len <= GOOD_COPY_LEN && !skb_queue_empty_lockless(&vvs->rx_queue)) {
> > >
> > > Same here.
> > >
> > > If there are no major changes to be made, I think the next version is the
> > > final ones, though we are now in the merge window, so net-next is closed
> > > [1], only RFCs can be sent [2].
> > >
> > > I suggest you wait until the merge window is over (two weeks usually) to
> > > send the next version.
> >
> > Nah, you never know, could be more comments. And depending on the timing
> > I might be able to merge it.
>
> Right, in the end these changes are only to virtio-vsock transport, so they
> can go smoothly even with your tree.
>
> @Bobby, so if you can fix the remaining small things, we can try to merge it
> :-)
>
> Thanks,
> Stefano

Sure thing. I'll change / send now.

Best,
Bobby