Re: [PATCH 0/5] Improvements to incremental builds

From: Ian Rogers
Date: Tue Dec 13 2022 - 16:32:06 EST


On Mon, Dec 12, 2022 at 12:31 PM Nicolas Schier <nicolas@xxxxxxxxx> wrote:
>
> On Thu, Dec 01, 2022 at 08:57:38PM -0800 Ian Rogers wrote:
> > Switching to using install_headers caused incremental builds to always
> > rebuild most targets. This was caused by the headers always being
> > reinstalled and then getting new timestamps causing dependencies to be
> > rebuilt. Follow the convention in libbpf where the install targets are
> > separated and trigger when the target isn't present or is out-of-date.
> >
> > Further, fix an issue in the perf build with libpython where
> > python/perf.so was also regenerated as the target name was incorrect.
> >
> > Ian Rogers (5):
> > tools lib api: Add dependency test to install_headers
> > tools lib perf: Add dependency test to install_headers
> > tools lib subcmd: Add dependency test to install_headers
> > tools lib symbol: Add dependency test to install_headers
> > perf build: Fix python/perf.so library's name
> >
> > tools/lib/api/Makefile | 38 ++++++++++++++++++++++-----------
> > tools/lib/perf/Makefile | 43 +++++++++++++++++++-------------------
> > tools/lib/subcmd/Makefile | 23 +++++++++++---------
> > tools/lib/symbol/Makefile | 21 ++++++++++++-------
> > tools/perf/Makefile.config | 4 +++-
> > tools/perf/Makefile.perf | 2 +-
> > 6 files changed, 79 insertions(+), 52 deletions(-)
> >
> > --
> > 2.39.0.rc0.267.gcb52ba06e7-goog
>
> Hi Ian,
>
> which tree is your patch set based on? At least it doesn't apply on the
> current kbuild trees.
>
> Kind regards,
> Nicolas

Hi Nicolas,

for the perf tool the branch to follow is Arnaldo's perf/core one:
https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/?h=perf%2Fcore

I may have done this work on Arnaldo's tmp.perf/core branch, which is
used for work-in-progress merges.

Thanks,
Ian

> --
> epost|xmpp: nicolas@xxxxxxxxx irc://oftc.net/nsc
> ↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f
> -- frykten for herren er opphav til kunnskap --