Re: [PATCH v2 01/12] dt-bindings: display: msm: Rename mdss node name in example

From: Dmitry Baryshkov
Date: Tue Dec 13 2022 - 17:12:38 EST




On 13 December 2022 23:53:48 EET, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote:
>
>
>On 12/1/2022 11:54 AM, Dmitry Baryshkov wrote:
>> On 30/11/2022 22:09, Adam Skladowski wrote:
>>> Follow other YAMLs and replace mdss name into display-subystem.
>>>
>>> Signed-off-by: Adam Skladowski <a39.skl@xxxxxxxxx>
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>
>Going to add two fixes tags here as we are touching two chipsets:
>
>Fixes: b93bdff44a85 ("dt-bindings: display/msm: add support for SM6115")
>Fixes: 06097b13ef97 ("dt-bindings: display/msm: split dpu-qcm2290 into DPU and MDSS parts")

Note, your tag gif wrapped, so patchwork will pick it up incorrectly.

>
>Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
>
>>
>> We will pick this into msm-fixes during the next cycle.
>
>Yes, we can with the above fixes tags but first, can you please send a MR from msm-next-lumag to msm-next? So that I can send a MR for fixes to msm-next.

This would create an additional merge commit in msm-next for no particular reason. You can branch -fixes from rc1, or from the msm-next-lumag and then send MR to msm-next.

>
>ATM, they are out of sync.
>
>
>>
>>> ---
>>>   .../devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml      | 2 +-
>>>   .../devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml       | 2 +-
>>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
>>> index d6f043a4b08d..4795e13c7b59 100644
>>> --- a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
>>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
>>> @@ -72,7 +72,7 @@ examples:
>>>       #include <dt-bindings/interconnect/qcom,qcm2290.h>
>>>       #include <dt-bindings/power/qcom-rpmpd.h>
>>> -    mdss@5e00000 {
>>> +    display-subsystem@5e00000 {
>>>           #address-cells = <1>;
>>>           #size-cells = <1>;
>>>           compatible = "qcom,qcm2290-mdss";
>>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
>>> index a86d7f53fa84..886858ef6700 100644
>>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
>>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
>>> @@ -62,7 +62,7 @@ examples:
>>>       #include <dt-bindings/interrupt-controller/arm-gic.h>
>>>       #include <dt-bindings/power/qcom-rpmpd.h>
>>> -    mdss@5e00000 {
>>> +    display-subsystem@5e00000 {
>>>           #address-cells = <1>;
>>>           #size-cells = <1>;
>>>           compatible = "qcom,sm6115-mdss";
>>

--
With best wishes
Dmitry