Re: [PATCH] scsi: scsi_debug: Delete unreachable code in inquiry_vpd_b0()
From: Jason Yan
Date: Tue Dec 13 2022 - 20:18:54 EST
On 2022/12/13 22:21, John Garry wrote:
The 2nd return statement in inquiry_vpd_b0() is unreachable, so delete it.
Signed-off-by: John Garry <john.g.garry@xxxxxxxxxx>
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index b8a76b89f85a..6f637501539c 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -1511,8 +1511,6 @@ static int inquiry_vpd_b0(unsigned char *arr)
put_unaligned_be64(sdebug_write_same_length, &arr[32]);
return 0x3c; /* Mandatory page length for Logical Block Provisioning */
-
- return sizeof(vpdb0_data);
}
/* Block device characteristics VPD page (SBC-3) */
Looks good,
Reviewed-by: Jason Yan <yanaijie@xxxxxxxxxx>