Re: [PATCH 1/4] arm64: dts: qcom: Introduce a carveout for modem metadata

[Sibi Sankar]

Hey Krzysztof,

Thanks for taking time to review the series.

On 12/14/22 01:10, Krzysztof Kozlowski wrote:
> On 13/12/2022 15:07, Sibi Sankar wrote:
> > Introduce a new carveout for modem metadata. This will serve as a
> > replacement for the memory region used by MSA to authenticate modem
> > ELF headers.
> >
> > Signed-off-by: Sibi Sankar <quic_sibis@xxxxxxxxxxx>
>
> Thank you for your patch. There is something to discuss/improve.
>
> >   
> >   	aliases {
> > @@ -865,7 +870,7 @@ hp_i2c: &i2c9 {
> >   	clock-names = "iface", "bus", "nav", "snoc_axi", "mnoc_axi", "xo";
> >   
> >   	iommus = <&apps_smmu 0x461 0x0>, <&apps_smmu 0x444 0x3>;
> > -	memory-region = <&mba_mem &mpss_mem>;
> > +	memory-region = <&mba_mem>, <&mpss_mem>, <&mdata_mem>;
> >   
> >   	/* This gets overridden for SKUs with LTE support. */
> >   	firmware-name = "qcom/sc7180-trogdor/modem-nolte/mba.mbn",
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi
> > index bf522a64b172..bda0495aa0b5 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi
> > @@ -17,6 +17,11 @@
> >   			reg = <0x0 0x9c700000 0x0 0x200000>;
> >   			no-map;
> >   		};
> > +
> > +		mdata_mem: memory@9d100000 {
> > +			reg = <0x0 0x9d100000 0x0 0x4000>;
> > +			no-map;
> > +		};
> >   	};
> >   };
> >   
> > @@ -32,7 +37,7 @@
> >   
> >   	iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>;
> >   	interconnects = <&mc_virt MASTER_LLCC 0 &mc_virt SLAVE_EBI1 0>;
> > -	memory-region = <&mba_mem>, <&mpss_mem>;
> > +	memory-region = <&mba_mem>, <&mpss_mem>, <&mdata_mem>;
>
> Only two memory regions are allowed by bindings... unless you fix it in
> further patchset. If so, please re-order to have the bindings first. It
> helps reviewers not to have such questions. :)

I felt that Rob's dt_bindings check bot might report an error
if the dt changes weren't placed before the bindings changes.
But since you asked for the logical order I guess the bindings
check are done only after the entire series is applied. I'll
change the order in the next re-spin.

- Sibi
> Best regards,
> Krzysztof