Re: [PATCH v7] igb: Assign random MAC address instead of fail in case of invalid one

[梁礼学]

hi Leon,

Currently this module parameter is only used for igb.
Is the more user-friendly way not to use module parameters?
just like other network card drivers, use random MAC. 
As I submitted [patch v3] before, link: 
https://lore.kernel.org/netdev/20220530105834.97175-1-lianglixuehao@xxxxxxx/

Or, can you suggest me how to do it more reasonable?

Thanks

> 2022年12月14日 15:22，Leon Romanovsky <leon@xxxxxxxxxx> 写道：
> 
> On Tue, Dec 13, 2022 at 07:47:26AM +0000, Lixue Liang wrote:
>> From: Lixue Liang <lianglixue@xxxxxxxxxxxxxxxx>
>> 
>> Add the module parameter "allow_invalid_mac_address" to control the
>> behavior. When set to true, a random MAC address is assigned, and the
>> driver can be loaded, allowing the user to correct the invalid MAC address.
>> 
>> Signed-off-by: Lixue Liang <lianglixue@xxxxxxxxxxxxxxxx>
> 
> 
> I'm amused that we are in v7 version of module parameter.
> 
> NAK to any module driver parameter. If it is applicable to all drivers,
> please find a way to configure it to more user-friendly. If it is not,
> try to do the same as other drivers do.
> 
> Thanks