Re: [PATCH v1 0/5] build/libtraceevent resends
From: Ian Rogers
Date: Wed Dec 14 2022 - 13:11:06 EST
On Wed, Dec 14, 2022 at 10:00 AM Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> wrote:
>
> Em Wed, Dec 14, 2022 at 11:22:45AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Tue, Dec 13, 2022 at 03:26:46PM -0800, Ian Rogers escreveu:
> > > All patches on the acme perf/core branch.
> > >
> > > Resend incremental build fix python plugin:
> > > https://lore.kernel.org/lkml/20221205225940.3079667-4-irogers@xxxxxxxxxx/
> > >
> > > Break apart and resend libtraceevent debug logging support:
> > > https://lore.kernel.org/linux-perf-users/20210923001024.550263-4-irogers@xxxxxxxxxx/
> > >
> > > Switch "#if HAVE_LIBTRACEEVENT_TEP_FIELD_IS_RELATIVE" to "#if
> > > MAKE_LIBTRACEEVENT_VERSION(1, 5, 0) <= LIBTRACEEVENT_VERSION",
> > > ensuring trace-event.h is included as discussed on the mailing list.
> > >
> > > Resend removal of --group option:
> > > https://lore.kernel.org/lkml/20220707195610.303254-1-irogers@xxxxxxxxxx/
> >
> > Thanks, applied.
>
> Building on arm64:
>
> /home/acme/git/perf/tools/perf/util/evsel.c: In function ‘evsel__rawptr’:
> /home/acme/git/perf/tools/perf/util/evsel.c:2787:65: error: operator '<=' has no right operand
> 2787 | #if MAKE_LIBTRACEEVENT_VERSION(1, 5, 0) <= LIBTRACEEVENT_VERSION
> | ^
> error: command '/usr/bin/gcc' failed with exit code 1
> cp: cannot stat '/tmp/build/perf/python_ext_build/lib/perf*.so': No such file or directory
>
> make[2]: *** [Makefile.perf:651: /tmp/build/perf/python/perf.cpython-310-aarch64-linux-gnu.so] Error 1
> make[2]: *** Waiting for unfinished jobs....
> LD /tmp/build/perf/libbpf/staticobjs/libbpf-in.o
>
> Trying to fix...
Thanks, I suspect the CFLAGS aren't passed through maybe, given this
is the python code. Perhaps an include of util/trace-event.h is also
necessary, but I thought that was already present:
https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/util/evsel.c?h=perf/core#n43
Thanks for digging into it,
Ian
> > - Arnaldo
> >
> >
> > > Ian Rogers (5):
> > > perf build: Fix python/perf.so library's name
> > > perf trace-event: Add libtraceevent version tools to header
> > > libtraceevent: Increase libtraceevent logging when verbose
> > > perf trace-event: Use version check to avoid 1 define
> > > perf evlist: Remove group option.
> > >
> > > tools/perf/Documentation/perf-record.txt | 4 ----
> > > tools/perf/Documentation/perf-top.txt | 7 ++----
> > > tools/perf/Makefile.config | 8 +++----
> > > tools/perf/Makefile.perf | 2 +-
> > > tools/perf/builtin-record.c | 2 --
> > > tools/perf/builtin-stat.c | 6 -----
> > > tools/perf/builtin-top.c | 2 --
> > > tools/perf/builtin-trace.c | 2 +-
> > > tools/perf/tests/attr/README | 2 --
> > > tools/perf/tests/attr/test-record-group | 22 -------------------
> > > tools/perf/tests/attr/test-stat-group | 17 --------------
> > > tools/perf/util/data-convert-bt.c | 3 ++-
> > > tools/perf/util/debug.c | 10 +++++++++
> > > tools/perf/util/evlist.c | 2 +-
> > > tools/perf/util/evlist.h | 2 --
> > > tools/perf/util/evsel.c | 2 +-
> > > tools/perf/util/python.c | 10 +--------
> > > tools/perf/util/record.c | 7 ------
> > > tools/perf/util/record.h | 1 -
> > > .../util/scripting-engines/trace-event-perl.c | 2 +-
> > > .../scripting-engines/trace-event-python.c | 2 +-
> > > tools/perf/util/sort.c | 3 ++-
> > > tools/perf/util/trace-event.h | 13 +++++++++++
> > > 23 files changed, 39 insertions(+), 92 deletions(-)
> > > delete mode 100644 tools/perf/tests/attr/test-record-group
> > > delete mode 100644 tools/perf/tests/attr/test-stat-group
> > >
> > > --
> > > 2.39.0.314.g84b9a713c41-goog
> >
> > --
> >
> > - Arnaldo
>
> --
>
> - Arnaldo