Re: [PATCH 0/7] improve AP queue reset processing

[Anthony Krowiak]

On 12/14/22 10:16 AM, Jason J. Herne wrote:
> On 12/13/22 10:44 AM, Tony Krowiak wrote:
> > This series introduces several improvements to the function that 
> > performs
> > AP queue resets:
> >
> > * Breaks up reset processing into multiple smaller, more concise 
> > functions.
> >
> > * Use TAPQ to verify completion of a reset in progress rather than 
> > mulitple
> >    invocations of ZAPQ.
> >
> > * Check TAPQ response codes when verifying successful completion of 
> > ZAPQ.
> >
> > * Fix erroneous handling of some error response codes.
> >
> > * Increase the maximum amount of time to wait for successful 
> > completion of
> >    ZAPQ.
> >
> > * Always clean up IRQ resources when the ZAPQ response code indicates an
> >    error.
> >
> > * Consider reset complete when ZAPQ response code indicates the 
> > adapter to
> >    which a queue is connected is deconfigured. All queues associated 
> > with an
> >    adapter are reset when it is deconfigured.
> >
> > Tony Krowiak (7):
> >    s390/vfio-ap: verify reset complete in separate function
> >    s390/vfio_ap: check TAPQ response code when waiting for queue reset
> >    s390/vfio_ap: use TAPQ to verify reset in progress completes
> >    s390/vfio_ap: verify ZAPQ completion after return of response code
> >      zero
> >    s390/vfio_ap: fix handling of error response codes
> >    s390/vfio_ap: increase max wait time for reset verification
> >    s390/vfio_ap: always clean up IRQ resources
> >
> >   drivers/s390/crypto/vfio_ap_ops.c | 106 ++++++++++++++++++++----------
> >   1 file changed, 73 insertions(+), 33 deletions(-)
>
>
> This series largely matches what I've already reviewed. I like the way 
> you broke this up, it does a better job telling the story.
>
> Here's my R-b for the entire series.
> Reviewed-by: Jason J. Herne <jjherne@xxxxxxxxxxxxx>


Thanks for the review Jason.