Re: [PATCH v7] igb: Assign random MAC address instead of fail in case of invalid one

[Jakub Kicinski]

On Wed, 14 Dec 2022 20:53:30 +0200 Leon Romanovsky wrote:
> On Wed, Dec 14, 2022 at 08:51:06AM -0800, Jakub Kicinski wrote:
> > On Wed, 14 Dec 2022 09:22:13 +0200 Leon Romanovsky wrote:  
> > > NAK to any module driver parameter. If it is applicable to all drivers,
> > > please find a way to configure it to more user-friendly. If it is not,
> > > try to do the same as other drivers do.  
> > 
> > I think this one may be fine. Configuration which has to be set before
> > device probing can't really be per-device.  
> 
> This configuration can be different between multiple devices
> which use same igb module. Module parameters doesn't allow such
> separation.

Configuration of the device, sure, but this module param is more of 
a system policy. BTW the name of the param is not great, we're allowing
the use of random address, not an invalid address.

> Also, as a user, I despise random module parameters which I need
> to set after every HW update/replacement.

Agreed, IIUC the concern was alerting users to incorrect EEPROM values.
I thought falling back to a random address was relatively common, but
I haven't done the research.