Re: [PATCH v8 2/7] media: dt-binding: nuvoton: Add bindings for NPCM VCD and ECE engine

[Krzysztof Kozlowski]

On 14/12/2022 10:26, Marvin Lin wrote:
> Add dt-binding document for Video Capture/Differentiation Engine (VCD)
> and Encoding Compression Engine (ECE) present on Nuvoton NPCM SoCs.

Subject: drop second, redundant "bindings for".

> 
> Signed-off-by: Marvin Lin <milkfafa@xxxxxxxxx>
> ---
>  .../bindings/media/nuvoton,npcm-ece.yaml      | 44 ++++++++++++
>  .../bindings/media/nuvoton,npcm-vcd.yaml      | 72 +++++++++++++++++++
>  2 files changed, 116 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/nuvoton,npcm-ece.yaml
>  create mode 100644 Documentation/devicetree/bindings/media/nuvoton,npcm-vcd.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/nuvoton,npcm-ece.yaml b/Documentation/devicetree/bindings/media/nuvoton,npcm-ece.yaml
> new file mode 100644
> index 000000000000..d12b76d137d9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/nuvoton,npcm-ece.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +

Drop blank line.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/nuvoton,npcm-ece.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton NPCM Encoding Compression Engine
> +
> +maintainers:
> +  - Joseph Liu <kwliu@xxxxxxxxxxx>
> +  - Marvin Lin <kflin@xxxxxxxxxxx>
> +
> +description: |
> +  Video Encoding Compression Engine (ECE) present on Nuvoton NPCM SoCs.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - nuvoton,npcm750-ece
> +      - nuvoton,npcm845-ece
> +
> +  reg:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - resets
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/reset/nuvoton,npcm7xx-reset.h>
> +
> +    ece: ece@f0820000 {

If this is video codec, then generic node name: "video-codec". "ece" is
specific, not generic.

> +        compatible = "nuvoton,npcm750-ece";
> +        reg = <0xf0820000 0x2000>;
> +        resets = <&rstc NPCM7XX_RESET_IPSRST2 NPCM7XX_RESET_ECE>;
> +    };
> diff --git a/Documentation/devicetree/bindings/media/nuvoton,npcm-vcd.yaml b/Documentation/devicetree/bindings/media/nuvoton,npcm-vcd.yaml
> new file mode 100644
> index 000000000000..2d8da8f36506
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/nuvoton,npcm-vcd.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +

Drop blank line.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/nuvoton,npcm-vcd.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton NPCM Video Capture/Differentiation Engine
> +
> +maintainers:
> +  - Joseph Liu <kwliu@xxxxxxxxxxx>
> +  - Marvin Lin <kflin@xxxxxxxxxxx>
> +
> +description: |
> +  Video Capture/Differentiation Engine (VCD) present on Nuvoton NPCM SoCs.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - nuvoton,npcm750-vcd
> +      - nuvoton,npcm845-vcd
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +  nuvoton,sysgcr:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: phandle to access GCR (Global Control Register) registers.
> +
> +  nuvoton,sysgfxi:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: phandle to access GFXI (Graphics Core Information) registers.
> +
> +  nuvoton,ece:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: phandle to access ECE (Encoding Compression Engine) registers.
> +
> +  memory-region:
> +    description:
> +      CMA pool to use for buffers allocation instead of the default CMA pool.

maxItems: 1

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - resets
> +  - nuvoton,sysgcr
> +  - nuvoton,sysgfxi
> +  - nuvoton,ece
> +
> +additionalProperties: false
> +
> 

Best regards,
Krzysztof