Re: [PATCH v1] block, bfq: do the all counting of pending-request if CONFIG_BFQ_GROUP_IOSCHED is enabled

From: Jan Kara
Date: Thu Dec 15 2022 - 05:27:21 EST


Hello Yuwei!

On Thu 15-12-22 09:48:59, Yuwei Guan wrote:
> Yu Kuai <yukuai1@xxxxxxxxxxxxxxx> 于2022年11月14日周一 11:33写道:
> >
> > Hi,
> >
> > 在 2022/11/10 19:26, Yuwei Guan 写道:
> > > The 'bfqd->num_groups_with_pending_reqs' is used when
> > > CONFIG_BFQ_GROUP_IOSCHED is enabled, so let the variables and processes
> > > take effect when ONFIG_BFQ_GROUP_IOSCHED is enabled.
> > >
> >
> > This patch looks good to me, fell free to add:
> > Reviewed-by: Yu Kuai <yukuai3@xxxxxxxxxx>
> >
> > BTW, this patch need to be reviewed by Jan or Paolo before it can be
> > applied.
>
> Could you help to review this patch.

Yeah, the patch looks good to me. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR