Re: [PATCH 3/7] staging: vc04_services: Drop VCHIQ_ERROR usage

[Umang Jain]

Hi Stefan,

On 12/15/22 5:00 PM, Stefan Wahren wrote:
> Hi Umang,
>
> thanks for taking care of this.
>
> Am 15.12.22 um 07:58 schrieb Umang Jain:
> > Drop the usage of VCHIQ_ERROR vchiq_status enum type. Replace it with
> > -EINVAL to report the error.
>
> I would prefer to use adequate error codes like ENOMEM and so on. I 
> agree simply replacing all VCHIQ_ERROR with -EINVAL is easier, but 
> wasn't the real intention of the TODO item.

I agree with you on that front - I am still trying to understand the 
bits of pieces of the vchiq driver as you can see it's not obvious to me.

I will try to address this is in v2 - after the series a bit more feedback.
> The rest of the series looks good to me.

Okay :-)
Thanks for prompt review.
> Best regards