Re: [PATCH] pinctrl: nomadik: include linux/seq_file.h

From: Andy Shevchenko
Date: Thu Dec 15 2022 - 12:17:12 EST


On Thu, Dec 15, 2022 at 06:00:57PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> In some randconfig builds, the missing #include causes a
> build failure:
>
> drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip':
> drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
> 1084 | seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank,
> | ^~~~~~~~~~
> | bstr_printf

Hmm... Strange that I have not noticed this from CIs.
Nevertheless, I have a patch that adds more missing
headers to this driver. I have planned to send it
after v6.2-rc1.

I'm fine if this goes first. Up to Linus.

--
With Best Regards,
Andy Shevchenko