Re: [RFC][PATCH] ACPI: tracing: Have ACPI debug go to tracing ring buffer

From: Steven Rostedt
Date: Thu Dec 15 2022 - 14:12:10 EST


On Thu, 15 Dec 2022 18:45:37 +0000
Joel Fernandes <joel@xxxxxxxxxxxxxxxxx> wrote:

> Wouldn't it be better to also check trace_acpi_print_enabled() here in the
> else if() condition, along with IS_ENABLED()? That way if the CONFIG is
> enabled but the tracepoint is not enabled, at least the messages will go to
> dmesg instead of skipped.

I really don't want that. This was purposely done to be mutually exclusive.
The reason I added this in the first place, is because too much enabled
will render the system useless if printk() is used.

After boot up, if I had enabled all debug events and then I were to disable
the acpi tracepoint, it will likely render the system useless again if it
were to switch over to printk.

-- Steve