Re: [PATCH] cros_ec_keyb: Add 3 buttons for monitor function

From: Prashant Malani
Date: Thu Dec 15 2022 - 17:59:00 EST


Hi Joe,

On Wed, Dec 14, 2022 at 10:15 PM Joe Wu
<joewu@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> This patch is to add extra 3 buttons: 'brightness up',
> 'brightness down' and 'leave PC(cros) mode' to support
> monitor navigation function.

nit: Please use the imperative form [1] while describing patches.
In this case, that would translate to:
"Add extra 3 buttons..."

Thanks,

-Prashant

[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes