Re: [PATCH] workqueue: Add a new flag to spot the potential UAF error

From: richard clark
Date: Thu Dec 15 2022 - 20:14:40 EST


Hello TJ,

On Wed, Dec 14, 2022 at 3:16 PM Lai Jiangshan <jiangshanlai@xxxxxxxxx> wrote:
>
> On Tue, Dec 13, 2022 at 12:40 PM Richard Clark
> <richard.xnu.clark@xxxxxxxxx> wrote:
> >
> > Currently if the user queues a new work item unintentionally
> > into a wq after the destroy_workqueue(wq), the work still can
> > be queued and scheduled without any noticeable kernel message
> > before the end of a RCU grace period.
> >
> > As a debug-aid facility, this commit adds a new flag
> > __WQ_DESTROYING to spot that issue by triggering a kernel WARN
> > message.
> >
> > Signed-off-by: Richard Clark <richard.xnu.clark@xxxxxxxxx>
>
> Reviewed-by: Lai Jiangshan <jiangshanlai@xxxxxxxxx>

What do I need to do for this patch next?

Thanks