Re: [PATCH v7 10/20] gunyah: rsc_mgr: Add resource manager RPC core

From: Elliot Berman
Date: Thu Dec 15 2022 - 21:25:37 EST




On 12/12/2022 10:26 PM, Greg Kroah-Hartman wrote:
On Mon, Dec 12, 2022 at 03:46:53PM -0800, Elliot Berman wrote:

Reference counting is not needed on the gh_rm_rpc object because its only
client (the VM manager) is torn down before the gh_rm_rpc.

So again, who controls the lifecycle of it? Where is the reference
count for the structure as it is pointing to reference counted memory?

Had some internal review and I think I'm now taking better care of this (and the device situation in the other mail). I will send out next revision soon.

In summary:

- Incrementing platform device's refcount when creating a new VM since it spawns new file descriptor that could remain open after closing the main miscdevice.
- Re-organizing vm_manager so it is much more like a library than a separate device.

Thanks,
Elliot