Re: [PATCH] dmaengine: qcom: gpi: Set link_rx bit on GO TRE for rx operation

[Vijaya Krishna Nivarthi]

Gentle reminder to review/approve please.

Thank you...


On 11/30/2022 5:50 PM, Vijaya Krishna Nivarthi wrote:
> As per GSI spec, link_rx bit is to be set on GO TRE on tx
> channel whenever there is going to be a DMA TRE on rx
> channel. This is currently set for duplex operation only.
>
> Set the bit for rx operation as well.
>
> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@xxxxxxxxxxx>
> ---
>   drivers/dma/qcom/gpi.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index 061add8..59a36cb 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
> @@ -1756,6 +1756,7 @@ static int gpi_create_spi_tre(struct gchan *chan, struct gpi_desc *desc,
>   		tre->dword[3] = u32_encode_bits(TRE_TYPE_GO, TRE_FLAGS_TYPE);
>   		if (spi->cmd == SPI_RX) {
>   			tre->dword[3] |= u32_encode_bits(1, TRE_FLAGS_IEOB);
> +			tre->dword[3] |= u32_encode_bits(1, TRE_FLAGS_LINK);
>   		} else if (spi->cmd == SPI_TX) {
>   			tre->dword[3] |= u32_encode_bits(1, TRE_FLAGS_CHAIN);
>   		} else { /* SPI_DUPLEX */