Re: [PATCH v1] soc: mediatek: mtk-pm-domains: Allow mt8186 ADSP default power on

[Matthias Brugger]

On 02/12/2022 12:13, TingHan Shen (沈廷翰) wrote:
> Hi Matthias,
>
> On Wed, 2022-11-23 at 18:40 +0800, TingHan Shen wrote:
> > On Wed, 2022-11-23 at 11:20 +0100, Matthias Brugger wrote:
> > > 
> > > On 12/10/2022 09:54, Tinghan Shen wrote:
> > > > In the use case of configuring the access permissions of the ADSP core,
> > > > the mt8186 SoC ADSP power will be switched on in the bootloader because
> > > > the permission control registers are located in the ADSP subsys.
> > > > 
> > > > Signed-off-by: Tinghan Shen <tinghan.shen@xxxxxxxxxxxx>
> > > 
> > > Do we need a fixes tag here?
> > > My bet is:
> > > Fixes: 88590cbc1703 ("soc: mediatek: pm-domains: Add support for mt8186")
> > > 
> > > Or is this not yet a problem but needed to be able to implement access 
> > > permission configuration in the ADSP driver?
> > > 
> > > Regards,
> > > Matthias
> >
> > This patch is needed to fix a warning when implementing the ADSP access permission configuration in preloader.
> >
> > [    0.334154] mtk-power-controller 10006000.syscon:power-controller: /soc/syscon@10006000/power-controller/power-domain@18/power-domain@19/power-domain@20: A default off power domain has been
> > ON
> > [    0.334246] ------------[ cut here ]------------
> > [    0.334252] top_adsp_bus already disabled
> > [    0.334274] WARNING: CPU: 5 PID: 113 at drivers/clk/clk.c:969 clk_core_disable+0x90/0xb0
> >
> > If not for this case, the pm-domain works fine.
> >
> >
> > Best regards,
> > TingHan
>
> gentle ping for this.
> from above descriptions, should I add the fixes tag to this patch?

No that's not needed in this case. Applied now.

Matthias