Re: [PATCHv1 linux-next 1/4] dt-bindings: net: rockchip-dwmac: fix rv1126 compatible warning

From: Slade Watkins
Date: Sat Dec 24 2022 - 16:24:46 EST


On Sat, Dec 24, 2022 at 9:30 AM Jagan Teki <jagan@xxxxxxxxxx> wrote:
>
> On Fri, 23 Dec 2022 at 18:55, Anand Moon <anand@xxxxxxxxxx> wrote:
> >
> > Fix compatible string for RV1126 gmac, and constrain it to
> > be compatible with Synopsys dwmac 4.20a.
> >
> > fix below warning
> > arch/arm/boot/dts/rv1126-edgeble-neu2-io.dtb: ethernet@ffc40000:
> > compatible: 'oneOf' conditional failed, one must be fixed:
> > ['rockchip,rv1126-gmac', 'snps,dwmac-4.20a'] is too long
> > 'rockchip,rv1126-gmac' is not one of ['rockchip,rk3568-gmac', 'rockchip,rk3588-gmac']
> >
> > Signed-off-by: Anand Moon <anand@xxxxxxxxxx>
> > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxx>
> > ---
>
> Please add Fixes above SoB.

That and, shouldn't the Signed-off-by: tags be reversed if Anand is
sending this?

Confused,

-- Slade