Re: [PATCH v17 3/3] EDAC/npcm: Add NPCM memory controller driver

From: Borislav Petkov
Date: Sun Dec 25 2022 - 23:51:01 EST


On Mon, Dec 26, 2022 at 11:50:54AM +0800, Kun-Fa Lin wrote:
> > > + syndrome = priv->location ? 1 << priv->bit :
> > > + data_synd[priv->bit];
> >
> > syndrome = priv->location ? 1 << priv->bit
> > : data_synd[priv->bit];
>
> Just to confirm the indentation, is it right as follows?
>
> syndrome = priv->location ? 1 << priv->bit
> : data_synd[priv->bit];
>
> And I was wondering if I should just remove the line break and let it stick out?

The idea is to have the '?' and the ':' under each other so that one
can visually immediately "parse" where each of the sides of the ternary
statement start.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette