Aw: Re: [next v7 8/8] arm64: dts: mt7986: add Bananapi R3

From: Frank Wunderlich
Date: Tue Dec 27 2022 - 04:44:30 EST



> Gesendet: Samstag, 24. Dezember 2022 um 20:00 Uhr
> Von: "Daniel Golle" <daniel@xxxxxxxxxxxxxx>

> > +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts

> > +&spi0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&spi_flash_pins>;
> > + cs-gpios = <0>, <0>;
>
> I don't think those bogus cs-gpios here and for spi1 below are needed.

at first look it seems it is needed...as i get this trace with 6.2:

[ 2.145931] pc : mtk_spi_can_dma+0x0/0x34
[ 2.155212] lr : mtk_spi_interrupt+0x74/0x360

[ 2.091801] mtk-spi 1100a000.spi: spi-mem transfer timeout
[ 2.097310] spi-nor: probe of spi0.0 failed with error -110
[ 2.102930] Unable to handle kernel read from unreadable memory at virtual address 0000000000000010

but i get the same trace when reverting the cs-gpios change....seems something is broken in 6.2-rc1

6.1 works without the bogus cs-gpios (and the mt7531 interrupt-change)...

have tried reverting this commit, but it does not fix the issue:

8330e9e8269b 2022-12-07 spi: spi-mtk-nor: Add recovery mechanism for dma read timeout

any idea without doing a bisect?

regards Frank

> > + status = "okay";
> > +};
> > +
> > +&spi1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&spic_pins>;
> > + cs-gpios = <0>, <0>;
> > + status = "okay";
> > +};