Re: [PATCH v2] mfd: axp20x: fix order of pek rise and fall events
From: Samuel Holland
Date: Tue Dec 27 2022 - 22:58:02 EST
On 12/8/22 16:02, Aren Moynihan wrote:
> The power button can get "stuck" if the rising edge and falling edge irq
> are read in the same pass. This can often be triggered when resuming
> from suspend if the power button is released before the kernel handles
> the interrupt.
>
> Swapping the order of the rise and fall events makes sure that the press
> event is handled first, which prevents this situation.
>
> Signed-off-by: Aren Moynihan <aren@xxxxxxxxxxxxxxxxx>
> ---
> changes in v2:
> - add comments describing the reason these are out of bit order
>
> previous version:
> https://lore.kernel.org/lkml/20221123230741.2430813-1-aren@xxxxxxxxxxxxxxxxx/T/
>
> include/linux/mfd/axp20x.h | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
Reviewed-by: Samuel Holland <samuel@xxxxxxxxxxxx>
Tested-by: Samuel Holland <samuel@xxxxxxxxxxxx>