Re: [PATCH] pinctrl: nomadik: include linux/seq_file.h

From: Andy Shevchenko
Date: Wed Dec 28 2022 - 03:53:09 EST


On Thu, Dec 15, 2022 at 07:16:54PM +0200, Andy Shevchenko wrote:
> On Thu, Dec 15, 2022 at 06:00:57PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@xxxxxxxx>
> >
> > In some randconfig builds, the missing #include causes a
> > build failure:
> >
> > drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip':
> > drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
> > 1084 | seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank,
> > | ^~~~~~~~~~
> > | bstr_printf
>
> Hmm... Strange that I have not noticed this from CIs.
> Nevertheless, I have a patch that adds more missing
> headers to this driver. I have planned to send it
> after v6.2-rc1.
>
> I'm fine if this goes first. Up to Linus.

FYI: I have just sent my version
https://lore.kernel.org/r/20221228084310.85210-1-andriy.shevchenko@xxxxxxxxxxxxxxx

--
With Best Regards,
Andy Shevchenko