Re: [PATCH 1/2] arm64: dts: qcom: sm8350: add missing core_bi_pll_test_se GCC clock

From: Dmitry Baryshkov
Date: Wed Dec 28 2022 - 09:35:22 EST


On 28/12/2022 16:25, Krzysztof Kozlowski wrote:
On 28/12/2022 13:50, Dmitry Baryshkov wrote:
On 28/12/2022 13:55, Krzysztof Kozlowski wrote:
On 28/12/2022 12:37, Konrad Dybcio wrote:


On 28.12.2022 12:24, Krzysztof Kozlowski wrote:
The GCC bindings expect core_bi_pll_test_se clock input, even if it is
optional:

sm8350-mtp.dtb: clock-controller@100000: clock-names:2: 'core_bi_pll_test_se' was expected

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
---
Is it even going to be used by anybody, or should we just drop
it on the driver side as per usual?

It's mentioned as possible parent, so there might be users somewhere...
Or you want to say that other binding and DTS users cannot use that clock?

Yes. In the past few months we have been removing the core_bi_pll_test
from the old clock drivers (and new clock drivers mostly lack them).
Let's remove it from the rest of clock drivers.

If you are going to start doing the same work, please at least share it
upfront.

Excuse me.

--
With best wishes
Dmitry