RE: [RFC PATCH v1 18/19] rtw88: Add support for the SDIO based RTL8822CS chipset

From: Ping-Ke Shih
Date: Wed Dec 28 2022 - 20:40:38 EST

Next message: Linus Walleij: "Re: [PATCH 1/2] gpio: vf610: connect GPIO label to dev name"
Previous message: Guenter Roeck: "Re: [PATCH v3] Add support for the AYANEO AIR and AYANEO AIR Pro models of handheld devices. These devices use the same EC registers and logic as the One X Player mini AMD. Previous AYANEO models are not supported as they use a different EC and do not have the necessary fan speed write enable and setting registers. The driver is tested on AYANEO AIR while AIR Pro model EC functionality and DMI data were verified using command line tools by another user."
In reply to: Martin Blumenstingl: "[RFC PATCH v1 18/19] rtw88: Add support for the SDIO based RTL8822CS chipset"
Next in thread: Martin Blumenstingl: "[RFC PATCH v1 19/19] rtw88: Add support for the SDIO based RTL8821CS chipset"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> -----Original Message-----
> From: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> Sent: Wednesday, December 28, 2022 7:30 AM
> To: linux-wireless@xxxxxxxxxxxxxxx
> Cc: Yan-Hsuan Chuang <tony0620emma@xxxxxxxxx>; Kalle Valo <kvalo@xxxxxxxxxx>; Ulf Hansson
> <ulf.hansson@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> linux-mmc@xxxxxxxxxxxxxxx; Chris Morgan <macroalpha82@xxxxxxxxx>; Nitin Gupta <nitin.gupta981@xxxxxxxxx>;
> Neo Jou <neojou@xxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx>; Jernej Skrabec <jernej.skrabec@xxxxxxxxx>;
> Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> Subject: [RFC PATCH v1 18/19] rtw88: Add support for the SDIO based RTL8822CS chipset
>
> Wire up RTL8822CS chipset support using the new rtw88 SDIO HCI code as
> well as the existing RTL8822C chipset code.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> ---
> drivers/net/wireless/realtek/rtw88/Kconfig | 11 ++++++
> drivers/net/wireless/realtek/rtw88/Makefile | 3 ++
> .../net/wireless/realtek/rtw88/rtw8822cs.c | 34 +++++++++++++++++++
> 3 files changed, 48 insertions(+)
> create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8822cs.c
>

[...]

> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822cs.c
> b/drivers/net/wireless/realtek/rtw88/rtw8822cs.c
> new file mode 100644
> index 000000000000..3d7279d70aa9
> --- /dev/null
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8822cs.c
> @@ -0,0 +1,34 @@
> +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
> +// Copyright(c) Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>

Normally, we should use '/* ... */' style comment. The exception is
'// SPDX-License-Identifier: ...' in *.c

Therefore, here should be:

// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
/* Copyright(c) Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
*/

As well as other rtw88*s.c

--
Ping-Ke