Re: [PATCH v3 2/4] dt-bindings: regulator: Add mps,mpq7932 power-management IC
From: Guenter Roeck
Date: Thu Dec 29 2022 - 09:08:41 EST
On Wed, Dec 07, 2022 at 06:37:14PM +0100, Saravanan Sekar wrote:
> Document mpq7932 power-management IC
>
> Signed-off-by: Saravanan Sekar <saravanan@xxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Since this is in the regulator subsystem domain, I can not apply the
patch through hwmon without Acked-by: or Reviewed-by: from a regulator
maintainer.
Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>
assuming that it will be applied through the regulator subsystem.
Turns out you did not actually copy a a regulator subsystem maintainer
or the regulator mailing list, so you'll have to re-send this patch for
inclusion there.
Guenter
> ---
> .../bindings/regulator/mps,mpq7932.yaml | 68 +++++++++++++++++++
> 1 file changed, 68 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/mps,mpq7932.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/mps,mpq7932.yaml b/Documentation/devicetree/bindings/regulator/mps,mpq7932.yaml
> new file mode 100644
> index 000000000000..2185cd011c46
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mps,mpq7932.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/mps,mpq7932.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Monolithic Power System MPQ7932 PMIC
> +
> +maintainers:
> + - Saravanan Sekar <saravanan@xxxxxxxxxxx>
> +
> +properties:
> + compatible:
> + enum:
> + - mps,mpq7932
> +
> + reg:
> + maxItems: 1
> +
> + regulators:
> + type: object
> + description: |
> + list of regulators provided by this controller, must be named
> + after their hardware counterparts BUCK[1-6]
> +
> + patternProperties:
> + "^buck[1-6]$":
> + type: object
> + $ref: regulator.yaml#
> + unevaluatedProperties: false
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - regulators
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic@3 {
> + compatible = "mps,mpq7932";
> + reg = <0x3>;
> +
> + regulators {
> + buck1 {
> + regulator-name = "buck1";
> + regulator-min-microvolt = <1600000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-boot-on;
> + };
> +
> + buck2 {
> + regulator-name = "buck2";
> + regulator-min-microvolt = <1700000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-boot-on;
> + };
> + };
> + };
> + };
> +...