Re: [PATCH v3] dt-bindings: net: marvell,orion-mdio: Fix examples
From: Krzysztof Kozlowski
Date: Thu Dec 29 2022 - 10:00:56 EST
On 29/12/2022 15:51, Michał Grzelak wrote:
> Hi Krzysztof,
>
> On Thu, Dec 29, 2022 at 3:30 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>
>> On 29/12/2022 15:22, Michał Grzelak wrote:
>>> As stated in marvell-orion-mdio.txt deleted in commit 0781434af811f
>>> ("dt-bindings: net: orion-mdio: Convert to JSON schema") if
>>> 'interrupts' property is present, width of 'reg' should be 0x84.
>>> Otherwise, width of 'reg' should be 0x4. Fix 'examples:' and add
>>> constraints checking whether 'interrupts' property is present
>>> and validate it against fixed values in reg.
>>>
>>> Signed-off-by: Michał Grzelak <mig@xxxxxxxxxxxx>
>>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>>
>> If you do not know the process, here is a short explanation:
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>> versions. However, there's no need to repost patches *only* to add the
>> tags. The upstream maintainer will do that for acks received on the
>> version they apply.
>>
>> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>>
>> If a tag was not added on purpose, please state why and what changed.
>
> Deletion of tag wasn't on purpose, it was done by accident. Would you
> like me to resend the patch with it being added, or leave it as is?
No need, I added it here, so will be picked-up by maintainers.
Best regards,
Krzysztof