Re: [PATCH v5 10/10] fpga: m10bmc-sec: Add support for N6000

From: Xu Yilun
Date: Fri Dec 30 2022 - 01:20:43 EST


On 2022-12-26 at 19:58:49 +0200, Ilpo Järvinen wrote:
> Add support for PMCI-based flash access path and N6000 sec update
> support. Access to flash staging area is different for N6000 from that
> of the SPI interfaced counterparts.
>
> Introduce intel_m10bmc_flash_bulk_ops to allow interface specific
> differentiations for the flash access path for sec update and make
> m10bmc_sec_read/write() in sec update driver to use the new operations.
>
> If a failure is detected while altering the flash MUX, it seems safer
> to try to set it back and doesn't seem harmful. Likely there are enough
> troubles in that case anyway so setting it back fails too (which is
> harmless sans the small extra delay) or just confirms that the value
> wasn't changed.
>
> Co-developed-by: Tianfei zhang <tianfei.zhang@xxxxxxxxx>
> Signed-off-by: Tianfei zhang <tianfei.zhang@xxxxxxxxx>
> Co-developed-by: Russ Weight <russell.h.weight@xxxxxxxxx>
> Signed-off-by: Russ Weight <russell.h.weight@xxxxxxxxx>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

Acked-by: Xu Yilun <yilun.xu@xxxxxxxxx>

> ---
> drivers/fpga/intel-m10-bmc-sec-update.c | 65 ++++++++++-
> drivers/mfd/intel-m10-bmc-pmci.c | 145 ++++++++++++++++++++++++
> include/linux/mfd/intel-m10-bmc.h | 14 +++
> 3 files changed, 223 insertions(+), 1 deletion(-)