Re: [V2] media: jpeg: Fix multi-hw judgement

From: Bagas Sanjaya
Date: Fri Dec 30 2022 - 04:06:28 EST


On 12/29/22 15:19, Kyrie Wu (吴晗) wrote:
> On Wed, 2022-12-28 at 19:29 +0700, Bagas Sanjaya wrote:
>> On Fri, Dec 16, 2022 at 11:52:47AM +0800, Irui Wang wrote:
>> > From: kyrie wu <kyrie.wu@xxxxxxxxxxxx>
>> >
>> > some chips have multi-hw, but others have only one,
>> > modify the condition of multi-hw judgement
>>
>> nit: s/judgement/conditional block/ ...
>>
>> > -if (list_empty(&pdev->dev.devres_head)) {
>> > +if (!jpeg->variant->hw_arch) {
>>
>> ... like here (if block).
>>
>> Thanks.
>
> Hi Bagas,
>
> I can't get your suggestion exactly.
> Do you mean to change if (...) as follows:
> if (jpeg->variant->hw_arch)

No, not what I mean. I pointed you at the correct terminology
with your code as example.

Thanks.

--
An old man doll... just what I always wanted! - Clara