Re: [PATCH V4 0/3] Make the irqchip immutable

From: Bartosz Golaszewski
Date: Fri Dec 30 2022 - 11:00:02 EST


On Thu, Dec 29, 2022 at 3:56 PM Cixi Geng <cixi.geng@xxxxxxxxx> wrote:
>
> From: Cixi Geng <cixi.geng1@xxxxxxxxxx>
>
> Kernel warns about mutable irq_chips:
> "not an immutable chip, please consider fixing!"
>
> Make the struct irq_chip const, flag it as IRQCHIP_IMMUTABLE, add the
> new helper functions, and call the appropriate gpiolib functions.
>
> v2 changes:
> Split the patch by each driver. and other comment by baolin in[1]
>
> v3 changes:
> Fix cocci warnings test by lkp[2].
>
> v4 changes:
> Change the irq name.
> Keep the same coding style by using offset for irqd_to_hwirq(data)
> Add Reviewed-by tag.
>
> [1]:https://lore.kernel.org/all/97e244d4-6b5c-31c9-7329-b8deef615645@xxxxxxxxxxxxxxxxx/
> [2]:https://lore.kernel.org/all/202212240406.9Nm190P8-lkp@xxxxxxxxx/
>
> Cixi Geng (3):
> gpio: eic-sprd: Make the irqchip immutable
> gpio: gpio-pmic-eic-sprd: Make the irqchip immutable
> gpio: gpio-sprd: Make the irqchip immutable
>
> drivers/gpio/gpio-eic-sprd.c | 23 ++++++++++++++---------
> drivers/gpio/gpio-pmic-eic-sprd.c | 29 ++++++++++++++++++-----------
> drivers/gpio/gpio-sprd.c | 9 ++++++---
> 3 files changed, 38 insertions(+), 23 deletions(-)
>
>
> base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
> --
> 2.34.1
>

Series queued for fixes, thanks!

Bart