Re: [PATCH 2/3] arm64: dts: qcom: sm8250: Touch up audio hw nodes

From: Krzysztof Kozlowski
Date: Fri Dec 30 2022 - 11:08:46 EST


On 30/12/2022 14:50, Konrad Dybcio wrote:
> - Expand long clock-names into vertical lists
> - Shuffle properties around:
> - Make sure compatible goes first and status goes last
> - Make property order consistent between similar nodes
> - Fix up indentation
> - Remove stray newlines
> - Remove a redundant comment about swr2 being associated with TX macro
> (it's obvious by looking at the label property 10 lines below)
> - Change unnecessary interrupts-extended to interrupts
> - Disable SWR0 and WSA macro by default and enable them on SM8250 MTP and
> RB5, which were the only users
> - Remove stray #address/size-cells from txmacro, as it's not even
> supposed to have children

You duplicate here some work:
https://lore.kernel.org/all/20221225115844.55126-4-krzysztof.kozlowski@xxxxxxxxxx/

and maybe:
https://lore.kernel.org/all/167233461775.1099840.3444272939352778399.b4-ty@xxxxxxxxxx/

If you wish to avoid trivial cleanup conflicts, feel free to poke to my
pending branch:
https://github.com/krzk/linux/commits/pending/dt-bindings-qcom-new-and-fixes-for-warnings-linux-next

Also, this is a mixture of non-functional changes (re-ordering,
whitespace) with something close to functional (interrupts-extended ->
interrupts, disabling nodes in DTSI). These should be split.



Best regards,
Krzysztof